platoneko commented on code in PR #31215:
URL: https://github.com/apache/doris/pull/31215#discussion_r1508810111
##########
be/src/olap/compaction.cpp:
##########
@@ -846,4 +851,80 @@ void Compaction::_load_segment_to_cache() {
}
}
+void CloudCompactionMixin::build_basic_info() {
+ _output_version =
+ Version(_input_rowsets.front()->start_version(),
_input_rowsets.back()->end_version());
+
+ _newest_write_timestamp = _input_rowsets.back()->newest_write_timestamp();
+
+ std::vector<RowsetMetaSharedPtr> rowset_metas(_input_rowsets.size());
+ std::transform(_input_rowsets.begin(), _input_rowsets.end(),
rowset_metas.begin(),
+ [](const RowsetSharedPtr& rowset) { return
rowset->rowset_meta(); });
+ _cur_tablet_schema =
_tablet->tablet_schema_with_merged_max_schema_version(rowset_metas);
+}
+
+int64_t CloudCompactionMixin::get_compaction_permits() {
+ int64_t permits = 0;
+ for (auto&& rowset : _input_rowsets) {
+ permits += rowset->rowset_meta()->get_compaction_score();
+ }
+ return permits;
+}
+
+CloudCompactionMixin::CloudCompactionMixin(CloudStorageEngine& engine,
CloudTabletSPtr tablet,
+ const std::string& label)
+ : Compaction(tablet, label), _engine(engine) {}
+
+Status CloudCompactionMixin::execute_compact_impl(int64_t permits) {
+ OlapStopWatch watch;
+
+ build_basic_info();
+
+ LOG(INFO) << "start " << compaction_name() << ". tablet=" <<
_tablet->tablet_id()
+ << ", output_version=" << _output_version << ", permits: " <<
permits;
+
+ RETURN_IF_ERROR(merge_input_rowsets());
+
+
RETURN_IF_ERROR(_engine.meta_mgr().commit_rowset(*_output_rowset->rowset_meta().get(),
true));
+
+ // 4. modify rowsets in memory
+ RETURN_IF_ERROR(modify_rowsets());
+
+ return Status::OK();
+}
+
+Status CloudCompactionMixin::execute_compact() {
+ TEST_INJECTION_POINT("Compaction::do_compaction");
+ int64_t permits = get_compaction_permits();
+ Status st = execute_compact_impl(permits);
+ if (!st.ok()) {
+ garbage_collection();
+ return st;
+ }
+ _load_segment_to_cache();
+ return st;
+}
+
+Status CloudCompactionMixin::modify_rowsets() {
Review Comment:
Consider use pure virtual function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
