platoneko commented on code in PR #31215:
URL: https://github.com/apache/doris/pull/31215#discussion_r1508802051


##########
be/src/cloud/cloud_tablet.h:
##########
@@ -109,6 +109,69 @@ class CloudTablet final : public BaseTablet {
     void set_cumulative_compaction_cnt(int64_t cnt) { 
_cumulative_compaction_cnt = cnt; }
     void set_cumulative_layer_point(int64_t new_point);
 
+    int64_t last_cumu_compaction_failure_time() { return 
_last_cumu_compaction_failure_millis; }
+    void set_last_cumu_compaction_failure_time(int64_t millis) {
+        _last_cumu_compaction_failure_millis = millis;
+    }
+
+    int64_t last_base_compaction_failure_time() { return 
_last_base_compaction_failure_millis; }
+    void set_last_base_compaction_failure_time(int64_t millis) {
+        _last_base_compaction_failure_millis = millis;
+    }
+
+    int64_t last_full_compaction_failure_time() { return 
_last_full_compaction_failure_millis; }
+    void set_last_full_compaction_failure_time(int64_t millis) {
+        _last_full_compaction_failure_millis = millis;
+    }
+
+    int64_t last_cumu_compaction_success_time() { return 
_last_cumu_compaction_success_millis; }
+    void set_last_cumu_compaction_success_time(int64_t millis) {
+        _last_cumu_compaction_success_millis = millis;
+    }
+
+    int64_t last_base_compaction_success_time() { return 
_last_base_compaction_success_millis; }
+    void set_last_base_compaction_success_time(int64_t millis) {
+        _last_base_compaction_success_millis = millis;
+    }
+
+    int64_t last_full_compaction_success_time() { return 
_last_full_compaction_success_millis; }
+    void set_last_full_compaction_success_time(int64_t millis) {
+        _last_full_compaction_success_millis = millis;
+    }
+
+    int64_t last_base_compaction_schedule_time() { return 
_last_base_compaction_schedule_millis; }
+    void set_last_base_compaction_schedule_time(int64_t millis) {
+        _last_base_compaction_schedule_millis = millis;
+    }
+
+    std::vector<RowsetSharedPtr> pick_candidate_rowsets_to_base_compaction();

Review Comment:
   这个函数应该可以不用了,直接用 `traverse_rowsets`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to