Re: [PR] [Enhancement] [plsql] support drop store procedure (#30966) [doris]

[via GitHub]

xinyiZzz commented on code in PR #31001:
URL: https://github.com/apache/doris/pull/31001#discussion_r1496807049


##########
fe/fe-core/src/main/antlr4/org/apache/doris/nereids/PLParser.g4:
##########
@@ -324,11 +325,15 @@ package_body_item :
       declare_stmt_item
     | create_function_stmt
     | create_procedure_stmt
+    | drop_procedure_stmt
     ;
 
 create_procedure_stmt :
       (ALTER | CREATE (OR REPLACE)? | REPLACE) (PROCEDURE | PROC) 
multipartIdentifier create_routine_params? create_routine_options? (AS | IS)? 
declare_block_inplace? label_stmt? procedure_block (ident_pl SEMICOLON)?
     ;
+drop_procedure_stmt:
+      (DROP  (PROCEDURE | PROC) multipartIdentifier create_routine_params? 
create_routine_options?)

Review Comment:
   It seems don't need `create_routine_params` and `create_routine_options`, 
refer to /hive/hplsql/src/main/antlr4/org/apache/hive/hplsql/Hplsql.g4, our 
syntax is the same as hplsql
   
![image](https://github.com/apache/doris/assets/13197424/16e17046-caff-4654-a6a6-2f34d748142f)
   
   such as:
   `DROP PROCEDURE (IF EXISTS)? name=multipartIdentifier`
   or
   `DROP (PROCEDURE | PROC) (IF EXISTS)? name=multipartIdentifier`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org