Re: [PR] [Enhancement] [plsql] support drop store procedure (#30966) [doris]

[via GitHub]

xinyiZzz commented on code in PR #31001:
URL: https://github.com/apache/doris/pull/31001#discussion_r1495259325


##########
fe/fe-core/src/main/antlr4/org/apache/doris/nereids/DorisParser.g4:
##########
@@ -37,6 +37,7 @@ statement
     : statementBase # statementBaseAlias
     | CALL name=multipartIdentifier LEFT_PAREN (expression (COMMA 
expression)*)? RIGHT_PAREN #callProcedure
     | (ALTER | CREATE (OR REPLACE)? | REPLACE) (PROCEDURE | PROC) 
name=multipartIdentifier LEFT_PAREN .*? RIGHT_PAREN .*? #createProcedure
+    | DROP (PROCEDURE | PROC) name=multipartIdentifier #dropProcedure

Review Comment:
   Same as `PLParser.g4` `drop_procedure_stmt`



##########
fe/fe-core/src/main/antlr4/org/apache/doris/nereids/PLParser.g4:
##########
@@ -324,11 +325,15 @@ package_body_item :
       declare_stmt_item
     | create_function_stmt
     | create_procedure_stmt
+    | drop_procedure_stmt

Review Comment:
   In /hive/hplsql/src/main/antlr4/org/apache/hive/hplsql/Hplsql.g4
   
![image](https://github.com/apache/doris/assets/13197424/26b2b51c-d4b9-4341-91f7-5554da0f24bf)
   
   no `drop_procedure_stmt`, but I don't know why.



##########
fe/fe-core/src/main/antlr4/org/apache/doris/nereids/PLParser.g4:
##########
@@ -324,11 +325,15 @@ package_body_item :
       declare_stmt_item
     | create_function_stmt
     | create_procedure_stmt
+    | drop_procedure_stmt
     ;
 
 create_procedure_stmt :
       (ALTER | CREATE (OR REPLACE)? | REPLACE) (PROCEDURE | PROC) 
multipartIdentifier create_routine_params? create_routine_options? (AS | IS)? 
declare_block_inplace? label_stmt? procedure_block (ident_pl SEMICOLON)?
     ;
+drop_procedure_stmt:
+      (DROP  (PROCEDURE | PROC) multipartIdentifier create_routine_params? 
create_routine_options?)

Review Comment:
   `create_routine_params` and `create_routine_options` are not required,
   refer to /hive/hplsql/src/main/antlr4/org/apache/hive/hplsql/Hplsql.g4,
   
![image](https://github.com/apache/doris/assets/13197424/d47b681a-e91b-4084-9893-1f691b1b14ab)
   
   we keep the same grammar as hplsql, such as:
   `DROP PROCEDURE (IF EXISTS)? name=multipartIdentifier`
   or
   `DROP (PROCEDURE | PROC) (IF EXISTS)? name=multipartIdentifier`
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org