Re: [PR] [fix](memory) Fix LRU cache stale sweep [doris]

[via GitHub]

xinyiZzz commented on code in PR #31122:
URL: https://github.com/apache/doris/pull/31122#discussion_r1495982223


##########
be/src/olap/lru_cache.cpp:
##########
@@ -622,20 +629,27 @@ uint64_t ShardedLRUCache::new_id() {
     return _last_id.fetch_add(1, std::memory_order_relaxed);
 }
 
-int64_t ShardedLRUCache::prune() {
-    int64_t num_prune = 0;
+std::tuple<PrunedCount, PrunedSize> ShardedLRUCache::prune() {

Review Comment:
   Using range view, code is not simplified. am I using it incorrectly?
   
![img_v3_0288_e473f88a-b82e-4289-a928-8efae267ffbg](https://github.com/apache/doris/assets/13197424/02ef4ea9-66a8-4596-bcd9-2c281a6e0f1c)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org