github-actions[bot] commented on code in PR #31122:
URL: https://github.com/apache/doris/pull/31122#discussion_r1495852088
##########
be/src/olap/lru_cache.h:
##########
@@ -479,8 +486,10 @@ class DummyLRUCache : public Cache {
void* value(Handle* handle) override;
Slice value_slice(Handle* handle) override;
uint64_t new_id() override { return 0; };
- int64_t prune() override { return 0; };
- int64_t prune_if(CacheValuePredicate pred, bool lazy_mode = false)
override { return 0; };
+ PrunedInfo prune() override { return {0, 0}; };
+ PrunedInfo prune_if(CachePrunePredicate pred, bool lazy_mode = false)
override {
Review Comment:
warning: method 'prune_if' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static PrunedInfo prune_if(CachePrunePredicate pred, bool lazy_mode =
false) override {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
