yiguolei commented on code in PR #31122:
URL: https://github.com/apache/doris/pull/31122#discussion_r1495276003
##########
be/src/olap/lru_cache.h:
##########
@@ -479,8 +489,11 @@ class DummyLRUCache : public Cache {
void* value(Handle* handle) override;
Slice value_slice(Handle* handle) override;
uint64_t new_id() override { return 0; };
- int64_t prune() override { return 0; };
- int64_t prune_if(CacheValuePredicate pred, bool lazy_mode = false)
override { return 0; };
+ int64_t prune(int64_t* freed_size = nullptr) override { return 0; };
+ int64_t prune_if(CachePrunePredicate pred, int64_t* freed_size = nullptr,
Review Comment:
我觉得啊，你要不干脆返回std::tuple<free_count, free_size> 要不看着怪怪的，一个是return
返回值，一个是通过参数指针返回
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
