yiguolei commented on code in PR #31122:
URL: https://github.com/apache/doris/pull/31122#discussion_r1495274542
##########
be/src/olap/lru_cache.cpp:
##########
@@ -622,18 +635,18 @@ uint64_t ShardedLRUCache::new_id() {
return _last_id.fetch_add(1, std::memory_order_relaxed);
}
-int64_t ShardedLRUCache::prune() {
+int64_t ShardedLRUCache::prune(int64_t* freed_size) {
int64_t num_prune = 0;
for (int s = 0; s < _num_shards; s++) {
- num_prune += _shards[s]->prune();
+ num_prune += _shards[s]->prune(freed_size);
}
return num_prune;
}
-int64_t ShardedLRUCache::prune_if(CacheValuePredicate pred, bool lazy_mode) {
+int64_t ShardedLRUCache::prune_if(CachePrunePredicate pred, int64_t*
freed_size, bool lazy_mode) {
Review Comment:
一般把返回值，放到参数列表的最后面
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
