HappenLee commented on code in PR #30900:
URL: https://github.com/apache/doris/pull/30900#discussion_r1491924539
##########
be/src/exprs/runtime_filter.h:
##########
@@ -276,20 +273,21 @@ class IRuntimeFilter {
Status merge_from(const RuntimePredicateWrapper* wrapper);
- // for ut
static Status create_wrapper(RuntimeFilterParamsContext* state,
const MergeRuntimeFilterParams* param,
ObjectPool* pool,
std::unique_ptr<RuntimePredicateWrapper>*
wrapper);
static Status create_wrapper(RuntimeFilterParamsContext* state,
const UpdateRuntimeFilterParams* param,
ObjectPool* pool,
std::unique_ptr<RuntimePredicateWrapper>*
wrapper);
+
static Status create_wrapper(RuntimeFilterParamsContext* state,
- const UpdateRuntimeFilterParamsV2* param,
ObjectPool* pool,
- std::unique_ptr<RuntimePredicateWrapper>*
wrapper);
+ const UpdateRuntimeFilterParamsV2* param,
Review Comment:
This lifecycle is more complex in RF, the use of Pool is to better reuse
memory, and the next PR will refactor this part of the code and unify it into
Pool.
after update the patch，next version of doris only use V2， we can delete the
old `update filter` api
##########
be/src/exprs/runtime_filter.h:
##########
@@ -276,20 +273,21 @@ class IRuntimeFilter {
Status merge_from(const RuntimePredicateWrapper* wrapper);
- // for ut
static Status create_wrapper(RuntimeFilterParamsContext* state,
const MergeRuntimeFilterParams* param,
ObjectPool* pool,
std::unique_ptr<RuntimePredicateWrapper>*
wrapper);
static Status create_wrapper(RuntimeFilterParamsContext* state,
const UpdateRuntimeFilterParams* param,
ObjectPool* pool,
std::unique_ptr<RuntimePredicateWrapper>*
wrapper);
+
static Status create_wrapper(RuntimeFilterParamsContext* state,
- const UpdateRuntimeFilterParamsV2* param,
ObjectPool* pool,
- std::unique_ptr<RuntimePredicateWrapper>*
wrapper);
+ const UpdateRuntimeFilterParamsV2* param,
Review Comment:
This lifecycle is more complex in RF, the use of Pool is to better reuse
memory, and the next PR will refactor this part of the code and unify it into
Pool.
after update the patch，next version of doris only use V2， we can delete the
old `update filter` api code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
