HappenLee commented on code in PR #30900:
URL: https://github.com/apache/doris/pull/30900#discussion_r1491922989


##########
be/src/exprs/runtime_filter.cpp:
##########
@@ -735,7 +735,9 @@ class RuntimePredicateWrapper {
         _is_bloomfilter = true;
         // we won't use this class to insert or find any data
         // so any type is ok
-        
_context.bloom_filter_func.reset(create_bloom_filter(PrimitiveType::TYPE_INT));
+        
_context.bloom_filter_func.reset(create_bloom_filter(_column_return_type == 
INVALID_TYPE
+                                                                     ? 
PrimitiveType::TYPE_INT

Review Comment:
   the up comment tell the reason: 
   ```we won't use this class to insert or find any data
      so any type is ok
   ```
   
   after change the logic, the `_column_return_type` be valid in `apply 
filter`, can reuse the mem of it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to