hongkun-Shao commented on code in PR #30875: URL: https://github.com/apache/doris/pull/30875#discussion_r1482481351
########## be/src/agent/task_worker_pool.cpp: ########## @@ -132,13 +133,15 @@ void finish_task(const TFinishTaskRequest& finish_task_request) { constexpr int TASK_FINISH_MAX_RETRY = 3; while (try_time < TASK_FINISH_MAX_RETRY) { DorisMetrics::instance()->finish_task_requests_total->increment(1); + DorisBvarMetrics::instance()->finish_task_requests_total->increment(1); Review Comment: To be precise, the original metric framework was outdated and had poor performance. This PR only utilized the fast counter feature of the bvar class to replace all the original metrics -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org