gavinchou commented on code in PR #30875:
URL: https://github.com/apache/doris/pull/30875#discussion_r1479316205
##########
be/src/agent/task_worker_pool.cpp:
##########
@@ -132,13 +133,15 @@ void finish_task(const TFinishTaskRequest&
finish_task_request) {
constexpr int TASK_FINISH_MAX_RETRY = 3;
while (try_time < TASK_FINISH_MAX_RETRY) {
DorisMetrics::instance()->finish_task_requests_total->increment(1);
+ DorisBvarMetrics::instance()->finish_task_requests_total->increment(1);
Review Comment:
consider inherit from the original metrics and rewrite the `increment()` to
reduce numbers of files modified. e.g.
```c++
class BvarCounter : public IntCounter {
void increment(int64_t) { ... }
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
