BiteTheDDDDt commented on a change in pull request #6323:
URL: https://github.com/apache/incubator-doris/pull/6323#discussion_r683096713
##########
File path: be/src/service/backend_service.cpp
##########
@@ -339,4 +339,7 @@ void
BackendService::get_stream_load_record(TStreamLoadRecordResult& result,
}
}
+void BackendService::clean_trash() {
+ StorageEngine::instance()->start_trash_sweep(nullptr, true);
Review comment:
>
>
> It may takes a very long time to clean the trash. So I suggest to use a
async call.
I think this is already async, because of I use `oneway` to define the
function at thrift file.
[`gensrc/thrift/BackendService.thrift`](https://github.com/apache/incubator-doris/blob/3c899f690d124d612b0d91949872cd9fb9faab80/gensrc/thrift/BackendService.thrift)
`oneway void clean_trash();`
##########
File path: be/src/service/backend_service.cpp
##########
@@ -339,4 +339,7 @@ void
BackendService::get_stream_load_record(TStreamLoadRecordResult& result,
}
}
+void BackendService::clean_trash() {
+ StorageEngine::instance()->start_trash_sweep(nullptr, true);
Review comment:
>
>
> It may takes a very long time to clean the trash. So I suggest to use a
async call.
I think this is already async, because of I use `oneway` to define the
function at thrift file.
[`gensrc/thrift/BackendService.thrift`](https://github.com/apache/incubator-doris/blob/3c899f690d124d612b0d91949872cd9fb9faab80/gensrc/thrift/BackendService.thrift)
`oneway void clean_trash();`
##########
File path:
fe/fe-core/src/main/java/org/apache/doris/analysis/AdminCleanTrashStmt.java
##########
@@ -0,0 +1,73 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.analysis;
+
+import org.apache.doris.catalog.Catalog;
+import org.apache.doris.common.AnalysisException;
+import org.apache.doris.common.ErrorCode;
+import org.apache.doris.common.ErrorReport;
+import org.apache.doris.qe.ConnectContext;
+import org.apache.doris.system.Backend;
+import org.apache.doris.mysql.privilege.PrivPredicate;
+
+import com.google.common.collect.ImmutableMap;
+import com.google.common.collect.Lists;
+
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+
+public class AdminCleanTrashStmt extends DdlStmt {
+ private List<Backend> backends = Lists.newArrayList();
+
+ public AdminCleanTrashStmt(List<String> backends) {
+ ImmutableMap<Long, Backend> backendsInfo =
Catalog.getCurrentSystemInfo().getIdToBackend();
+ Map<String, Long> backendsID = new HashMap<String, Long>();
+ for (Backend backend : backendsInfo.values()) {
+ backendsID.put(String.valueOf(backend.getHost()) + ":" +
String.valueOf(backend.getHeartbeatPort()), backend.getId());
+ }
+ if (backends == null) {
+ for (Backend backend : backendsInfo.values()) {
+ this.backends.add(backend);
+ }
+ } else {
+ for (String backend : backends) {
+ if (backendsID.get(backend) != null) {
+
this.backends.add(backendsInfo.get(backendsID.get(backend)));
+ backendsID.remove(backend); // avoid repetition
+ }
+ }
+ }
+ }
+
+ public List<Backend> getBackends() {
+ return backends;
+ }
+
+ @Override
+ public void analyze(Analyzer analyzer) throws AnalysisException {
+ if
(!Catalog.getCurrentCatalog().getAuth().checkGlobalPriv(ConnectContext.get(),
PrivPredicate.ADMIN)) {
+
ErrorReport.reportAnalysisException(ErrorCode.ERR_SPECIFIC_ACCESS_DENIED_ERROR,
"ADMIN");
+ }
+ }
+
+ @Override
+ public RedirectStatus getRedirectStatus() {
+ return RedirectStatus.FORWARD_WITH_SYNC;
Review comment:
>
>
> Do we need to forward this stmt to master?
This does not seem to modify the metadata, so I change it to NO_FORWARD at
9765d59
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
