BiteTheDDDDt commented on a change in pull request #6323:
URL: https://github.com/apache/incubator-doris/pull/6323#discussion_r683096713



##########
File path: be/src/service/backend_service.cpp
##########
@@ -339,4 +339,7 @@ void 
BackendService::get_stream_load_record(TStreamLoadRecordResult& result,
     }
 }
 
+void BackendService::clean_trash() {
+    StorageEngine::instance()->start_trash_sweep(nullptr, true);

Review comment:
       
   
   > 
   > 
   > It may takes a very long time to clean the trash. So I suggest to use a 
async call.
   
   I think this is already async, because of I use `oneway` to define the 
function at thrift file. 
   
[`gensrc/thrift/BackendService.thrift`](https://github.com/apache/incubator-doris/blob/3c899f690d124d612b0d91949872cd9fb9faab80/gensrc/thrift/BackendService.thrift)
   `oneway void clean_trash();`
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to