github-actions[bot] commented on code in PR #29818:
URL: https://github.com/apache/doris/pull/29818#discussion_r1455604782
##########
be/src/olap/storage_engine.cpp:
##########
@@ -430,46 +435,80 @@ Status StorageEngine::set_cluster_id(int32_t cluster_id) {
return Status::OK();
}
+StorageEngine::DiskRemainingLevel get_available_level(double
disk_usage_percent) {
+ assert(disk_usage_percent <= 1);
+ if (disk_usage_percent < 0.7) {
+ return StorageEngine::DiskRemainingLevel::LOW;
+ } else if (disk_usage_percent < 0.85) {
+ return StorageEngine::DiskRemainingLevel::MID;
+ }
+ return StorageEngine::DiskRemainingLevel::HIGH;
+}
+
+int StorageEngine::_get_and_set_next_disk_index(int64 partition_id,
Review Comment:
warning: method '_get_and_set_next_disk_index' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static int StorageEngine::_get_and_set_next_disk_index(int64 partition_id,
```
##########
be/src/olap/storage_engine.h:
##########
@@ -328,36 +334,12 @@ class StorageEngine {
void _decrease_low_priority_task_nums(DataDir* dir);
-private:
- struct CompactionCandidate {
- CompactionCandidate(uint32_t nicumulative_compaction_, int64_t
tablet_id_, uint32_t index_)
- : nice(nicumulative_compaction_), tablet_id(tablet_id_),
disk_index(index_) {}
- uint32_t nice; // priority
- int64_t tablet_id;
- uint32_t disk_index = -1;
- };
-
- // In descending order
- struct CompactionCandidateComparator {
- bool operator()(const CompactionCandidate& a, const
CompactionCandidate& b) {
- return a.nice > b.nice;
- }
- };
+ void _get_candidate_stores(TStorageMedium::type storage_medium,
+ std::vector<DirInfo>& dir_infos);
- struct CompactionDiskStat {
- CompactionDiskStat(std::string path, uint32_t index, bool used)
- : storage_path(path),
- disk_index(index),
- task_running(0),
- task_remaining(0),
- is_used(used) {}
- const std::string storage_path;
- const uint32_t disk_index;
- uint32_t task_running;
- uint32_t task_remaining;
- bool is_used;
- };
+ int _get_and_set_next_disk_index(int64 partition_id, TStorageMedium::type
storage_medium);
+private:
Review Comment:
warning: redundant access specifier has the same accessibility as the
previous access specifier [readability-redundant-access-specifiers]
```suggestion
```
<details>
<summary>Additional context</summary>
**be/src/olap/storage_engine.h:231:** previously declared here
```cpp
private:
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
