github-actions[bot] commented on code in PR #29818:
URL: https://github.com/apache/doris/pull/29818#discussion_r1452903952
##########
be/src/olap/storage_engine.cpp:
##########
@@ -129,7 +130,10 @@ StorageEngine::StorageEngine(const EngineOptions& options)
_memtable_flush_executor(nullptr),
_calc_delete_bitmap_executor(nullptr),
_default_rowset_type(BETA_ROWSET),
- _stream_load_recorder(nullptr) {
+ _heartbeat_flags(nullptr),
Review Comment:
warning: member initializer for '_heartbeat_flags' is redundant
[modernize-use-default-member-init]
```suggestion
,
```
##########
be/src/olap/storage_engine.h:
##########
@@ -488,6 +492,60 @@ class StorageEngine {
bool _clear_segment_cache = false;
std::atomic<bool> _need_clean_trash {false};
+
+ // next index for create tablet
+ std::map<TStorageMedium::type, int> _last_use_index;
+
+ std::unique_ptr<CreateTabletIdxCache> _create_tablet_idx_lru_cache;
+
+ DISALLOW_COPY_AND_ASSIGN(StorageEngine);
Review Comment:
warning: prefer deleting copy constructor and assignment operator over using
macro 'DISALLOW_COPY_AND_ASSIGN'
[modernize-replace-disallow-copy-and-assign-macro]
```suggestion
StorageEngine(const StorageEngine &) = delete;
const StorageEngine &operator=(const StorageEngine &) = delete;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
