platoneko commented on code in PR #28716:
URL: https://github.com/apache/doris/pull/28716#discussion_r1434737612
##########
be/src/olap/tablet.cpp:
##########
@@ -489,23 +523,6 @@ Status
Tablet::modify_rowsets(std::vector<RowsetSharedPtr>& to_add,
same_version = false;
}
- if (check_delete) {
Review Comment:
并且 `modify_rowsets` 这个函数实现越来越重了，tablet 对增减 rowset 接口抽象的很不好（可以注意到在 cooldown
那又搞了 delete_rowsets 和 add_rowsets 两个函数，原因是 modify_rowset 没法满足需求），未来需要大改
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
