platoneko commented on code in PR #28716:
URL: https://github.com/apache/doris/pull/28716#discussion_r1434737047
##########
be/src/olap/tablet.cpp:
##########
@@ -489,23 +523,6 @@ Status
Tablet::modify_rowsets(std::vector<RowsetSharedPtr>& to_add,
same_version = false;
}
- if (check_delete) {
Review Comment:
我感觉 `check_delete`
作为传参会更让人难以理解是做啥的并且忘记传入，我们这很多时候都是没理解代码去大块的copy别处的代码，直接写出来还能让人注意下
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
