amorynan commented on code in PR #28670:
URL: https://github.com/apache/doris/pull/28670#discussion_r1432181020
##########
be/src/vec/data_types/data_type_ipv6.cpp:
##########
@@ -37,8 +37,9 @@ std::string DataTypeIPv6::to_string(const IColumn& column,
size_t row_num) const
auto result = check_column_const_set_readability(column, row_num);
ColumnPtr ptr = result.first;
row_num = result.second;
- IPv6 value = assert_cast<const ColumnIPv6&>(*ptr).get_element(row_num);
- return convert_ipv6_to_string(value);
Review Comment:
why write convert before ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
