amorynan commented on code in PR #28670:
URL: https://github.com/apache/doris/pull/28670#discussion_r1432180179
##########
be/test/vec/data_types/from_string_test.cpp:
##########
@@ -283,6 +283,57 @@ TEST(FromStringTest, ScalaWrapperFieldVsDataType) {
}
}
+ // ipv4 and ipv6 type
+ {
+ typedef std::pair<FieldType, string> FieldType_RandStr;
+ std::vector<FieldType_RandStr> ip_scala_field_types = {
+ FieldType_RandStr(FieldType::OLAP_FIELD_TYPE_IPV4,
"127.0.0.1"),
+ FieldType_RandStr(FieldType::OLAP_FIELD_TYPE_IPV6,
"2405:9800:9800:66::2")};
Review Comment:
add max min case here. to make beut rung
##########
be/test/vec/data_types/from_string_test.cpp:
##########
@@ -283,6 +283,57 @@ TEST(FromStringTest, ScalaWrapperFieldVsDataType) {
}
}
+ // ipv4 and ipv6 type
+ {
+ typedef std::pair<FieldType, string> FieldType_RandStr;
+ std::vector<FieldType_RandStr> ip_scala_field_types = {
+ FieldType_RandStr(FieldType::OLAP_FIELD_TYPE_IPV4,
"127.0.0.1"),
+ FieldType_RandStr(FieldType::OLAP_FIELD_TYPE_IPV6,
"2405:9800:9800:66::2")};
Review Comment:
add max min case here. to make beut run
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
