github-actions[bot] commented on code in PR #27726:
URL: https://github.com/apache/doris/pull/27726#discussion_r1428683809


##########
be/src/vec/sink/group_commit_block_sink.cpp:
##########
@@ -218,5 +232,16 @@ Status GroupCommitBlockSink::_add_blocks() {
     return Status::OK();
 }
 
+const string& GroupCommitBlockSink::_get_min_disk_usage_dir(

Review Comment:
   warning: method '_get_min_disk_usage_dir' can be made static 
[readability-convert-member-functions-to-static]
   
   ```suggestion
   static const string& GroupCommitBlockSink::_get_min_disk_usage_dir(
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to