mymeiyi commented on code in PR #27726:
URL: https://github.com/apache/doris/pull/27726#discussion_r1426110483
##########
be/src/http/action/http_stream.cpp:
##########
@@ -169,25 +170,39 @@ int HttpStreamAction::on_header(HttpRequest* req) {
Status st = Status::OK();
std::string group_commit_mode = req->header(HTTP_GROUP_COMMIT);
- if (iequal(group_commit_mode, "off_mode")) {
- group_commit_mode = "";
- }
if (!group_commit_mode.empty() && !iequal(group_commit_mode, "sync_mode")
&&
!iequal(group_commit_mode, "async_mode") && !iequal(group_commit_mode,
"off_mode")) {
st = Status::InternalError("group_commit can only be [async_mode,
sync_mode, off_mode]");
- if (iequal(group_commit_mode, "off_mode")) {
- group_commit_mode = "";
- }
+ } else if (group_commit_mode.empty() || iequal(group_commit_mode,
"off_mode")) {
+ group_commit_mode = "off_mode";
Review Comment:
set group_commit_mode = "", otherwise it is confilct with line line 184
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
