morningman commented on a change in pull request #5737:
URL: https://github.com/apache/incubator-doris/pull/5737#discussion_r623586814
##########
File path: be/src/olap/storage_engine.cpp
##########
@@ -1035,4 +1035,76 @@ void
StorageEngine::create_base_compaction(TabletSharedPtr best_tablet,
base_compaction.reset(new BaseCompaction(best_tablet, tracker_label,
_compaction_mem_tracker));
}
+// Return json:
+// {
+// "CumulativeCompaction": {
+// "/home/disk1" : [10001, 10002],
Review comment:
It's OK, but since we already have metrics to show the max version
number of compaction task, I think it is enough for us to monitor the segment
number. And if we want to see the number of a certain compaction task, we can
just dive into the be.INFO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
