weizuo93 commented on a change in pull request #5737:
URL: https://github.com/apache/incubator-doris/pull/5737#discussion_r623570948



##########
File path: be/src/olap/storage_engine.cpp
##########
@@ -1035,4 +1035,76 @@ void 
StorageEngine::create_base_compaction(TabletSharedPtr best_tablet,
     base_compaction.reset(new BaseCompaction(best_tablet, tracker_label, 
_compaction_mem_tracker));
 }
 
+// Return json:
+// {
+//   "CumulativeCompaction": {
+//          "/home/disk1" : [10001, 10002],

Review comment:
       Can we add segment number that be merged in this compaction task for 
each thread or each disk? Of course, we could add the segment number info in 
another PR.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to