Nitin-Kashyap commented on code in PR #27784:
URL: https://github.com/apache/doris/pull/27784#discussion_r1414271680


##########
gensrc/thrift/Partitions.thrift:
##########
@@ -21,6 +21,13 @@ namespace java org.apache.doris.thrift
 include "Exprs.thrift"
 include "Types.thrift"
 
+enum THashType {
+    CRC32,
+    XXHASH64,
+    SPARK_MURMUR32,
+    HIVE_MOD

Review Comment:
   removed



##########
be/src/vec/utils/util.hpp:
##########
@@ -156,6 +156,10 @@ inline std::string remove_suffix(const std::string& name, 
const std::string& suf
     return name.substr(0, name.length() - suffix.length());
 };
 
+inline uint64_t pmod(const int64_t a, const int64_t b) {

Review Comment:
   removed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to