morningman commented on code in PR #27784:
URL: https://github.com/apache/doris/pull/27784#discussion_r1418762198
##########
fe/fe-core/src/main/java/org/apache/doris/planner/external/HiveScanNode.java:
##########
@@ -423,4 +430,37 @@ protected TFileCompressType getFileCompressType(FileSplit
fileSplit) throws User
}
return compressType;
}
+
+ @Override
+ public DataPartition constructInputPartitionByDistributionInfo() {
+ if (hmsTable.isBucketedTable()) {
+ DistributionInfo distributionInfo =
hmsTable.getDefaultDistributionInfo();
+ if (!(distributionInfo instanceof HashDistributionInfo)) {
+ return DataPartition.RANDOM;
+ }
+ List<Column> distributeColumns = ((HiveExternalDistributionInfo)
distributionInfo).getDistributionColumns();
+ List<Expr> dataDistributeExprs = Lists.newArrayList();
+ for (Column column : distributeColumns) {
+ SlotRef slotRef = new SlotRef(desc.getRef().getName(),
column.getName());
+ dataDistributeExprs.add(slotRef);
+ }
+ return DataPartition.hashPartitioned(dataDistributeExprs,
THashType.SPARK_MURMUR32);
+ }
+
+ return DataPartition.RANDOM;
+ }
+
+ public HMSExternalTable getHiveTable() {
+ return hmsTable;
+ }
+
+ @Override
+ public THashType getHashType() {
+ if (hmsTable.isBucketedTable()
+ && hmsTable.getDefaultDistributionInfo() instanceof
HashDistributionInfo) {
Review Comment:
If this is a "Hive" bucket table, here we still return "SPARK_MURMUR32"?
So my point is, we need a certain flag to tell that this is indeed a spark
table or hive table?
For example, add a field in `HashDistributionInfo` to save the certain hash
function?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
