csun5285 commented on code in PR #27764: URL: https://github.com/apache/doris/pull/27764#discussion_r1413788509
########## be/src/olap/tablet_schema.cpp: ########## @@ -1019,6 +1019,23 @@ bool TabletSchema::is_dropped_column(const TabletColumn& col) const { column(col.name()).unique_id() != col.unique_id(); } +void TabletSchema::copy_extracted_columns(const TabletSchema& src_schema) { + std::unordered_set<int32_t> variant_columns; + for (const auto& col : columns()) { + if (col.is_variant_type()) { + variant_columns.insert(col.unique_id()); + } + } + for (const TabletColumn& col : src_schema.columns()) { + if (col.is_extracted_column() && variant_columns.contains(col.parent_unique_id())) { + ColumnPB col_pb; + col.to_schema_pb(&col_pb); + TabletColumn new_col(col_pb); + append_column(new_col, ColumnType::VARIANT); Review Comment: The added columns here are all extracted from variants, such as v.id. They will only be duplicated if the user adds a column with the same name, like v.id. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org