xzj7019 commented on code in PR #27378:
URL: https://github.com/apache/doris/pull/27378#discussion_r1408707512
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/CollectJoinConstraint.java:
##########
@@ -92,27 +90,37 @@ public List<Rule> buildRules() {
}).toRule(RuleType.COLLECT_JOIN_CONSTRAINT),
logicalFilter().thenApply(ctx -> {
- LeadingHint leading = (LeadingHint) ctx.cascadesContext
- .getStatementContext().getHintMap().get("Leading");
- if (leading == null) {
+ if (!ctx.cascadesContext.isLeadingJoin()) {
return ctx.root;
}
+ LeadingHint leading = (LeadingHint) ctx.cascadesContext
+ .getHintMap().get("Leading");
LogicalFilter filter = ctx.root;
Set<Expression> expressions = filter.getConjuncts();
for (Expression expression : expressions) {
- Long filterBitMap = calSlotsTableBitMap(leading,
expression.getInputSlots(), false);
+ Long filterBitMap = 0L;
Review Comment:
Pls make sure this part of logic correctness and completeness, such as alias
handling, for both filter pullup and pushdown.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
