xzj7019 commented on code in PR #27378:
URL: https://github.com/apache/doris/pull/27378#discussion_r1408676861
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/hint/LeadingHint.java:
##########
@@ -191,6 +196,29 @@ public List<Pair<Long, Expression>> getFilters() {
return filters;
}
+ public void putFilterJoinType(Expression filter, JoinType joinType) {
+ filterJoinType.put(filter, joinType);
+ }
+
+ /**
+ * find out whether filters can match original joinType
+ * @param filters filters needs to put on this join
+ * @param joinType join type computed by join constraint
+ * @return can filters matched
+ */
+ public boolean isFilterJoinTypeMatched(List<Expression> filters, JoinType
joinType) {
+ for (Expression filter : filters) {
Review Comment:
Pls confirm the definition of filter and join condition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
