github-actions[bot] commented on code in PR #27641:
URL: https://github.com/apache/doris/pull/27641#discussion_r1407305556
##########
be/src/pipeline/pipeline_fragment_context.h:
##########
@@ -222,10 +226,18 @@ class PipelineFragmentContext : public
std::enable_shared_from_this<PipelineFrag
private:
static bool _has_inverted_index_or_partial_update(TOlapTableSink sink);
+ std::shared_ptr<QueryStatistics> _dml_query_statistics() {
Review Comment:
warning: method '_dml_query_statistics' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static std::shared_ptr<QueryStatistics> _dml_query_statistics() {
```
##########
be/src/runtime/plan_fragment_executor.h:
##########
@@ -278,6 +278,13 @@ class PlanFragmentExecutor {
void _collect_query_statistics();
+ std::shared_ptr<QueryStatistics> _dml_query_statistics() {
Review Comment:
warning: method '_dml_query_statistics' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static std::shared_ptr<QueryStatistics> _dml_query_statistics() {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
