HappenLee commented on code in PR #27641:
URL: https://github.com/apache/doris/pull/27641#discussion_r1407044654
##########
be/src/vec/exec/vexchange_node.cpp:
##########
@@ -147,11 +147,17 @@ void VExchangeNode::release_resource(RuntimeState* state)
{
Status VExchangeNode::collect_query_statistics(QueryStatistics* statistics) {
RETURN_IF_ERROR(ExecNode::collect_query_statistics(statistics));
+ if (statistics->collect_dml_statistics()) {
+ return Status::OK();
+ }
statistics->merge(_sub_plan_query_statistics_recvr.get());
return Status::OK();
}
Status VExchangeNode::collect_query_statistics(QueryStatistics* statistics,
int sender_id) {
RETURN_IF_ERROR(ExecNode::collect_query_statistics(statistics));
+ if (statistics->collect_dml_statistics()) {
+ return Status::OK();
Review Comment:
remove the useless ok，use if(!)
##########
be/src/vec/exec/vexchange_node.cpp:
##########
@@ -147,11 +147,17 @@ void VExchangeNode::release_resource(RuntimeState* state)
{
Status VExchangeNode::collect_query_statistics(QueryStatistics* statistics) {
RETURN_IF_ERROR(ExecNode::collect_query_statistics(statistics));
+ if (statistics->collect_dml_statistics()) {
+ return Status::OK();
+ }
statistics->merge(_sub_plan_query_statistics_recvr.get());
return Status::OK();
}
Status VExchangeNode::collect_query_statistics(QueryStatistics* statistics,
int sender_id) {
RETURN_IF_ERROR(ExecNode::collect_query_statistics(statistics));
+ if (statistics->collect_dml_statistics()) {
+ return Status::OK();
Review Comment:
remove the useless ok，use if(!)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
