yiguolei commented on code in PR #27229:
URL: https://github.com/apache/doris/pull/27229#discussion_r1398209241
##########
fe/fe-core/src/main/java/org/apache/doris/resource/workloadgroup/WorkloadGroup.java:
##########
@@ -61,9 +61,9 @@ public class WorkloadGroup implements Writable,
GsonPostProcessable {
public static final String QUEUE_TIMEOUT = "queue_timeout";
- private static final ImmutableSet<String> REQUIRED_PROPERTIES_NAME = new
ImmutableSet.Builder<String>().add(
- CPU_SHARE).add(MEMORY_LIMIT).build();
-
+ // NOTE(wb): all property is not required, some properties default value
is set in be
+ // default value is as followed
+ // cpu_share=1024, memory_limit=0%(0 means not limit),
enable_memory_overcommit=true
Review Comment:
If you add comment here, so why not set the default value in FE not in BE.
So that the logic in BE is very simple, it only need follow FE's value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
