github-actions[bot] commented on code in PR #27229:
URL: https://github.com/apache/doris/pull/27229#discussion_r1398123052
##########
be/src/runtime/task_group/task_group.h:
##########
@@ -139,6 +139,13 @@ class TaskGroup : public
std::enable_shared_from_this<TaskGroup> {
return _mem_tracker_limiter_pool;
}
+ // when mem_limit <=0 , it's an invalid value, then current group not
participating in memory GC
+ // because mem_limit is not a required property
+ bool is_mem_limit_valid() {
Review Comment:
warning: method 'is_mem_limit_valid' can be made const
[readability-make-member-function-const]
```suggestion
bool is_mem_limit_valid() const {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
