yiguolei commented on code in PR #26710:
URL: https://github.com/apache/doris/pull/26710#discussion_r1397091683
##########
be/src/runtime/fragment_mgr.cpp:
##########
@@ -654,45 +654,28 @@ Status FragmentMgr::_get_query_ctx(const Params& params,
TUniqueId query_id, boo
if constexpr (std::is_same_v<TPipelineFragmentParams, Params>) {
if (params.__isset.workload_groups &&
!params.workload_groups.empty()) {
- taskgroup::TaskGroupInfo task_group_info;
- auto status =
taskgroup::TaskGroupInfo::parse_group_info(params.workload_groups[0],
-
&task_group_info);
- if (status.ok()) {
- auto tg =
_exec_env->task_group_manager()->get_or_create_task_group(
- task_group_info);
- tg->add_mem_tracker_limiter(query_ctx->query_mem_tracker);
- uint64_t tg_id = tg->id();
- std::string tg_name = tg->name();
- LOG(INFO) << "Query/load id: " <<
print_id(query_ctx->query_id())
- << " use task group: " << tg->debug_string()
- << " cpu_hard_limit: " <<
task_group_info.cpu_hard_limit
- << " cpu_share:" << task_group_info.cpu_share
- << " enable cgroup soft cpu:" <<
config::enable_cgroup_cpu_soft_limit;
- if (task_group_info.cpu_hard_limit > 0) {
- Status ret =
_exec_env->task_group_manager()->create_and_get_task_scheduler(
- tg_id, tg_name, task_group_info.cpu_hard_limit,
- task_group_info.cpu_share, _exec_env,
query_ctx.get());
- if (!ret.ok()) {
- LOG(INFO) << "workload group init failed "
- << ", name=" << tg_name << ", id=" <<
tg_id
- << ", reason=" << ret.to_string();
- }
+ uint64_t tg_id = params.workload_groups[0].id;
+ auto* tg_mgr = _exec_env->task_group_manager();
+ if (auto task_group_ptr = tg_mgr->get_task_group_by_id(tg_id))
{
Review Comment:
下面这堆ss 的代码，感觉就是 task group to string啊，直接在task group 里写一个方法，然后保存就行了，不用每次都生成
##########
be/src/runtime/fragment_mgr.cpp:
##########
@@ -654,45 +654,28 @@ Status FragmentMgr::_get_query_ctx(const Params& params,
TUniqueId query_id, boo
if constexpr (std::is_same_v<TPipelineFragmentParams, Params>) {
if (params.__isset.workload_groups &&
!params.workload_groups.empty()) {
- taskgroup::TaskGroupInfo task_group_info;
- auto status =
taskgroup::TaskGroupInfo::parse_group_info(params.workload_groups[0],
-
&task_group_info);
- if (status.ok()) {
- auto tg =
_exec_env->task_group_manager()->get_or_create_task_group(
- task_group_info);
- tg->add_mem_tracker_limiter(query_ctx->query_mem_tracker);
- uint64_t tg_id = tg->id();
- std::string tg_name = tg->name();
- LOG(INFO) << "Query/load id: " <<
print_id(query_ctx->query_id())
- << " use task group: " << tg->debug_string()
- << " cpu_hard_limit: " <<
task_group_info.cpu_hard_limit
- << " cpu_share:" << task_group_info.cpu_share
- << " enable cgroup soft cpu:" <<
config::enable_cgroup_cpu_soft_limit;
- if (task_group_info.cpu_hard_limit > 0) {
- Status ret =
_exec_env->task_group_manager()->create_and_get_task_scheduler(
- tg_id, tg_name, task_group_info.cpu_hard_limit,
- task_group_info.cpu_share, _exec_env,
query_ctx.get());
- if (!ret.ok()) {
- LOG(INFO) << "workload group init failed "
- << ", name=" << tg_name << ", id=" <<
tg_id
- << ", reason=" << ret.to_string();
- }
+ uint64_t tg_id = params.workload_groups[0].id;
+ auto* tg_mgr = _exec_env->task_group_manager();
+ if (auto task_group_ptr = tg_mgr->get_task_group_by_id(tg_id))
{
Review Comment:
下面这堆ss 的代码，感觉就是 task group to string啊，直接在task group 里写一个方法，然后保存就行了，不用每次都生成
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
