yiguolei commented on code in PR #26710:
URL: https://github.com/apache/doris/pull/26710#discussion_r1396669213
##########
gensrc/thrift/BackendService.thrift:
##########
@@ -165,9 +165,8 @@ enum TTopicInfoType {
}
struct TopicInfo {
- 1: optional string topic_key
- 2: required TTopicInfoType topic_type
- 3: optional map<string, string> info_map
+ 1: optional TTopicInfoType topic_type
+ 2: optional map<string, string> info_map
Review Comment:
我感觉我们用string 传递不是很好，
##########
gensrc/thrift/BackendService.thrift:
##########
@@ -165,9 +165,8 @@ enum TTopicInfoType {
}
struct TopicInfo {
- 1: optional string topic_key
- 2: required TTopicInfoType topic_type
- 3: optional map<string, string> info_map
+ 1: optional TTopicInfoType topic_type
+ 2: optional map<string, string> info_map
Review Comment:
我感觉我们用string 传递不是很好，
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
