github-actions[bot] commented on code in PR #26465:
URL: https://github.com/apache/doris/pull/26465#discussion_r1387795358
##########
be/src/olap/schema.h:
##########
@@ -176,6 +176,15 @@ class Schema {
const std::vector<int32_t>& unique_ids() const { return _unique_ids; }
ColumnId column_id(size_t index) const { return _col_ids[index]; }
int32_t unique_id(size_t index) const { return _unique_ids[index]; }
+ size_t col_id_to_col_ids_index(int cid) const {
Review Comment:
warning: method 'col_id_to_col_ids_index' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static size_t col_id_to_col_ids_index(int cid) {
```
##########
be/src/vec/exec/scan/new_olap_scanner.cpp:
##########
@@ -104,6 +104,26 @@ static std::string read_columns_to_string(TabletSchemaSPtr
tablet_schema,
return read_columns_string;
}
+void NewOlapScanner::_perfect_slot_column_id(const VExprSPtr& expr) {
Review Comment:
warning: method '_perfect_slot_column_id' can be made static
[readability-convert-member-functions-to-static]
be/src/vec/exec/scan/new_olap_scanner.h:89:
```diff
- void _perfect_slot_column_id(const VExprSPtr& expr);
+ static void _perfect_slot_column_id(const VExprSPtr& expr);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
