github-actions[bot] commented on code in PR #26465:
URL: https://github.com/apache/doris/pull/26465#discussion_r1387211883
##########
be/src/olap/schema.h:
##########
@@ -176,6 +176,14 @@ class Schema {
const std::vector<int32_t>& unique_ids() const { return _unique_ids; }
ColumnId column_id(size_t index) const { return _col_ids[index]; }
int32_t unique_id(size_t index) const { return _unique_ids[index]; }
+ size_t unique_id_to_index(int32_t unique_id) const {
Review Comment:
warning: method 'unique_id_to_index' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static size_t unique_id_to_index(int32_t unique_id) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
