JackDrogon commented on code in PR #26467:
URL: https://github.com/apache/doris/pull/26467#discussion_r1386135259
##########
be/src/vec/aggregate_functions/aggregate_function_collect.h:
##########
@@ -547,6 +559,25 @@ class AggregateFunctionCollect
this->data(place).deserialize_and_merge(column, i);
}
} else {
+ if (version >= 4) {
Review Comment:
too many special judgment version >= 4, use factory method to refactor it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
