JackDrogon commented on code in PR #26467:
URL: https://github.com/apache/doris/pull/26467#discussion_r1386124927
##########
be/src/agent/be_exec_version_manager.h:
##########
@@ -62,8 +62,10 @@ class BeExecVersionManager {
* a. aggregation function do not serialize bitmap to string.
* b. array contains/position/countequal function return nullable in less
situations.
* c. cleared old version of Version 2.
+ * 4: start from doris 2.2
+ * a. aggregation: collect_list does not serialize the aggregation data to
string.
*/
-inline const int BeExecVersionManager::max_be_exec_version = 3;
+inline const int BeExecVersionManager::max_be_exec_version = 4;
Review Comment:
why not use constexpr
##########
be/src/vec/aggregate_functions/aggregate_function_collect.h:
##########
@@ -535,6 +535,18 @@ class AggregateFunctionCollect
if constexpr (ShowNull::value) {
this->data(place).insert_result_into(to);
} else {
+ if (version >= 4) {
Review Comment:
what's the meaning of 4
##########
be/src/vec/aggregate_functions/aggregate_function_collect.h:
##########
@@ -547,6 +559,25 @@ class AggregateFunctionCollect
this->data(place).deserialize_and_merge(column, i);
}
} else {
+ if (version >= 4) {
Review Comment:
too many special judge version >= 4, use factory method to refactor it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
