seawinde commented on code in PR #26055:
URL: https://github.com/apache/doris/pull/26055#discussion_r1382599382


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/BindExpression.java:
##########
@@ -564,10 +567,16 @@ protected boolean condition(Rule rule, Plan plan) {
             ),
             RuleType.BINDING_RESULT_SINK.build(
                 unboundResultSink().then(sink -> {
-                    List<NamedExpression> outputExprs = 
sink.child().getOutput().stream()
-                            .map(NamedExpression.class::cast)
-                            .collect(ImmutableList.toImmutableList());
-                    return new LogicalResultSink<>(outputExprs, sink.child());
+
+                    final ImmutableListMultimap.Builder<ExprId, Integer> 
exprIdToIndexMapBuilder =

Review Comment:
   Ctas stmt is only supported by legacy, It's already supported in another  pr 
[Infer the column name when create view if the column is 
expression](https://github.com/apache/doris/pull/24990), and when cats is 
supported in nereids future, this is also useful. the old and new optimizer 
should keep consistency when query and ddl



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to