seawinde commented on code in PR #26055: URL: https://github.com/apache/doris/pull/26055#discussion_r1381204175
########## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/visitor/PlanVisitors.java: ########## @@ -0,0 +1,84 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.nereids.trees.plans.visitor; + +import org.apache.doris.nereids.trees.expressions.Alias; +import org.apache.doris.nereids.trees.expressions.ExprId; +import org.apache.doris.nereids.trees.expressions.NamedExpression; +import org.apache.doris.nereids.trees.expressions.Slot; +import org.apache.doris.nereids.trees.plans.Plan; + +import com.google.common.collect.ImmutableCollection; +import com.google.common.collect.ImmutableMultimap; +import com.google.common.collect.ImmutableSet; + +import java.util.ArrayList; +import java.util.List; +import java.util.stream.Collectors; + +/** + * This is the facade and factory for plan visitor + */ +public class PlanVisitors { + + /** + * Infer output column name when it refers an expression and not has an alias manually. + */ + public static class InferPlanOutputAlias extends DefaultPlanVisitor<Void, ImmutableMultimap<ExprId, Integer>> { + + private final List<Slot> currentOutputs; + private final List<NamedExpression> finalOutputs; + + public InferPlanOutputAlias(List<Slot> currentOutputs) { + this.currentOutputs = currentOutputs; + this.finalOutputs = new ArrayList<>(currentOutputs); + } + + @Override + public Void visit(Plan plan, ImmutableMultimap<ExprId, Integer> context) { + + List<NamedExpression> projects = plan.getExpressions().stream() Review Comment: Want to get all node output expressions and check if it's in the currentExprIdAndIndex Map. if contains then infer the name. I see that getExpressions is the superset to getProjects, so I use the `getExpressions` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
