yiguolei commented on code in PR #26148:
URL: https://github.com/apache/doris/pull/26148#discussion_r1377072874
##########
be/src/util/runtime_profile.h:
##########
@@ -428,6 +433,8 @@ class RuntimeProfile {
void clear_children();
+ void set_pipelineX_exec_time(Counter* exec_timer) { _pipelineX_exec_time =
exec_timer; }
Review Comment:
尽量不要写这种set
这种写法会导致指针的生命周期很难控制
##########
be/src/util/runtime_profile.h:
##########
@@ -428,6 +433,8 @@ class RuntimeProfile {
void clear_children();
+ void set_pipelineX_exec_time(Counter* exec_timer) { _pipelineX_exec_time =
exec_timer; }
Review Comment:
尽量不要写这种set
这种写法会导致指针的生命周期很难控制
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
