yiguolei commented on code in PR #26148:
URL: https://github.com/apache/doris/pull/26148#discussion_r1377072039
##########
be/src/util/runtime_profile.h:
##########
@@ -333,7 +333,12 @@ class RuntimeProfile {
const std::string* get_info_string(const std::string& key);
// Returns the counter for the total elapsed time.
- Counter* total_time_counter() { return &_counter_total_time; }
+ Counter* total_time_counter() {
Review Comment:
不要这么改， 直接加一个新方法 exec_time_counter()， 你这么改，当我们看pipelinex的代码的时候，看profile
会很疑惑。
##########
be/src/util/runtime_profile.h:
##########
@@ -333,7 +333,12 @@ class RuntimeProfile {
const std::string* get_info_string(const std::string& key);
// Returns the counter for the total elapsed time.
- Counter* total_time_counter() { return &_counter_total_time; }
+ Counter* total_time_counter() {
Review Comment:
不要这么改， 直接加一个新方法 exec_time_counter()， 你这么改，当我们看pipelinex的代码的时候，看profile
会很疑惑。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
