bobhan1 commented on code in PR #26008:
URL: https://github.com/apache/doris/pull/26008#discussion_r1377025278


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/parser/LogicalPlanBuilder.java:
##########
@@ -432,12 +432,16 @@ public LogicalPlan 
visitInsertIntoQuery(InsertIntoQueryContext ctx) {
                 colNames,
                 ImmutableList.of(),
                 partitions,
-                
ConnectContext.get().getSessionVariable().isEnableUniqueKeyPartialUpdate(),
+                false,

Review Comment:
   Here it uses the session variable in the parser to analyze weather to use 
the semantic of partial update for the current insert statement.  However, we 
can't apply the effect of the hint of the current insert statement before we 
parse the statement itself, so I move the analysis of the semantic of partial 
update of the current insert statement to `BindSink`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to