morrySnow commented on code in PR #26008:
URL: https://github.com/apache/doris/pull/26008#discussion_r1375892803
##########
fe/fe-core/src/main/antlr4/org/apache/doris/nereids/DorisParser.g4:
##########
@@ -50,7 +50,7 @@ statement
(ROLLUP LEFT_PAREN rollupDefs RIGHT_PAREN)?
propertyClause?
(AS query)?
#createTable
- | explain? INSERT (INTO | OVERWRITE TABLE)
+ | explain? INSERT selectHint? (INTO | OVERWRITE TABLE)
Review Comment:
rename it to hint since we use it not just in select statement
##########
fe/fe-core/src/main/cup/sql_parser.cup:
##########
@@ -4841,16 +4841,16 @@ insert_overwrite_stmt ::=
// Insert statement
insert_stmt ::=
- KW_INSERT KW_INTO insert_target:target opt_with_label:label
opt_col_list:cols opt_plan_hints:hints insert_source:source
+ KW_INSERT opt_select_hints:insert_hints KW_INTO insert_target:target
opt_with_label:label opt_col_list:cols opt_plan_hints:hints insert_source:source
Review Comment:
ditto
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/parser/LogicalPlanBuilder.java:
##########
@@ -432,12 +432,16 @@ public LogicalPlan
visitInsertIntoQuery(InsertIntoQueryContext ctx) {
colNames,
ImmutableList.of(),
partitions,
-
ConnectContext.get().getSessionVariable().isEnableUniqueKeyPartialUpdate(),
+ false,
Review Comment:
this change is not about hint, please explain why do this change. add some
comment if necessary
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/SelectList.java:
##########
@@ -34,7 +34,7 @@
* Select list items plus distinct clause.
*/
public class SelectList {
- private static final String SET_VAR_KEY = "set_var";
+ public static final String SET_VAR_KEY = "set_var";
Review Comment:
move it into StatementBase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
