yiguolei commented on code in PR #26127: URL: https://github.com/apache/doris/pull/26127#discussion_r1376957932
########## be/src/vec/exprs/vexpr_context.cpp: ########## @@ -288,14 +288,21 @@ Status VExprContext::execute_conjuncts_and_filter_block(const VExprContextSPtrs& } Status VExprContext::get_output_block_after_execute_exprs( - const VExprContextSPtrs& output_vexpr_ctxs, const Block& input_block, Block* output_block) { + const VExprContextSPtrs& output_vexpr_ctxs, const Block& input_block, Block* output_block, Review Comment: add more comment to explain why we need this parameter -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org