yiguolei commented on code in PR #26127:
URL: https://github.com/apache/doris/pull/26127#discussion_r1376955076
##########
be/src/vec/exprs/vexpr_context.cpp:
##########
@@ -288,14 +288,21 @@ Status
VExprContext::execute_conjuncts_and_filter_block(const VExprContextSPtrs&
}
Status VExprContext::get_output_block_after_execute_exprs(
- const VExprContextSPtrs& output_vexpr_ctxs, const Block& input_block,
Block* output_block) {
+ const VExprContextSPtrs& output_vexpr_ctxs, const Block& input_block,
Block* output_block,
+ bool do_projection) {
+ auto rows = input_block.rows();
vectorized::Block tmp_block(input_block.get_columns_with_type_and_name());
vectorized::ColumnsWithTypeAndName result_columns;
for (auto& vexpr_ctx : output_vexpr_ctxs) {
int result_column_id = -1;
RETURN_IF_ERROR(vexpr_ctx->execute(&tmp_block, &result_column_id));
DCHECK(result_column_id != -1);
-
result_columns.emplace_back(tmp_block.get_by_position(result_column_id));
+ const auto& col = tmp_block.get_by_position(result_column_id);
+ if (do_projection) {
Review Comment:
may have performance issues
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
