Gabriel39 commented on code in PR #25713:
URL: https://github.com/apache/doris/pull/25713#discussion_r1369673635
##########
be/src/pipeline/pipeline_x/pipeline_x_task.h:
##########
@@ -153,6 +155,9 @@ class PipelineXTask : public PipelineTask {
OperatorXPtr _root;
DataSinkOperatorXPtr _sink;
+ std::vector<Dependency*> _operatorsDependency;
+ WriteDependency* _sinkDependency;
Review Comment:
```suggestion
WriteDependency* _write_dependencies;
```
##########
be/src/pipeline/pipeline_x/pipeline_x_task.h:
##########
@@ -141,6 +141,8 @@ class PipelineXTask : public PipelineTask {
return _upstream_dependency[id];
}
+ Status get_dependency_from_task();
Review Comment:
```suggestion
Status extract_dependencies();
```
##########
be/src/pipeline/pipeline_x/pipeline_x_task.h:
##########
@@ -153,6 +155,9 @@ class PipelineXTask : public PipelineTask {
OperatorXPtr _root;
DataSinkOperatorXPtr _sink;
+ std::vector<Dependency*> _operatorsDependency;
Review Comment:
```suggestion
std::vector<Dependency*> _read_dependencies;
```
##########
be/src/pipeline/pipeline_x/dependency.h:
##########
@@ -88,15 +89,13 @@ class Dependency : public
std::enable_shared_from_this<Dependency> {
void set_parent(std::weak_ptr<Dependency> parent) { _parent = parent; }
void add_child(std::shared_ptr<Dependency> child) {
- std::unique_lock<std::mutex> l(_lock);
_children.push_back(child);
child->set_parent(weak_from_this());
}
- void remove_first_child() {
- std::unique_lock<std::mutex> l(_lock);
- _children.erase(_children.begin());
- }
+ void remove_first_child() { _children.erase(_children.begin()); }
+
+ virtual bool is_not_fake() const { return true; }
Review Comment:
Maybe delete this function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
