github-actions[bot] commented on code in PR #25713:
URL: https://github.com/apache/doris/pull/25713#discussion_r1369679803


##########
be/src/pipeline/pipeline_x/operator.cpp:
##########
@@ -169,7 +172,7 @@ void PipelineXLocalStateBase::clear_origin_block() {
 
 Status OperatorXBase::do_projections(RuntimeState* state, vectorized::Block* 
origin_block,
                                      vectorized::Block* output_block) const {
-    auto local_state = state->get_local_state(id());
+    auto local_state = state->get_local_state(operator_id());

Review Comment:
   warning: 'auto local_state' can be declared as 'auto *local_state' 
[readability-qualified-auto]
   
   ```suggestion
       auto *local_state = state->get_local_state(operator_id());
   ```
   



##########
be/src/pipeline/pipeline_x/operator.cpp:
##########
@@ -202,7 +205,7 @@ Status OperatorXBase::do_projections(RuntimeState* state, 
vectorized::Block* ori
 
 Status OperatorXBase::get_next_after_projects(RuntimeState* state, 
vectorized::Block* block,
                                               SourceState& source_state) {
-    auto local_state = state->get_local_state(id());
+    auto local_state = state->get_local_state(operator_id());

Review Comment:
   warning: 'auto local_state' can be declared as 'auto *local_state' 
[readability-qualified-auto]
   
   ```suggestion
       auto *local_state = state->get_local_state(operator_id());
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to