AshinGau commented on code in PR #25591: URL: https://github.com/apache/doris/pull/25591#discussion_r1363604705
########## be/src/vec/exec/jni_connector.cpp: ########## @@ -311,8 +311,8 @@ Status JniConnector::_fill_column(TableMetaAddress& address, ColumnPtr& doris_co } MutableColumnPtr data_column; if (doris_column->is_nullable()) { - auto* nullable_column = reinterpret_cast<vectorized::ColumnNullable*>( - (*std::move(doris_column)).mutate().get()); Review Comment: `mutate` will return the copied column when `use_count > 1`, so use `assume_mutable` to get the mutable column. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org